Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not make the placeholder appearing when leaving a room on iPhone #5085

Closed
wants to merge 47 commits into from
Closed

Do not make the placeholder appearing when leaving a room on iPhone #5085

wants to merge 47 commits into from

Conversation

SBiOSoftWhare
Copy link
Contributor

Fix #5084

kittykat and others added 30 commits October 12, 2021 10:31
@kittykat
Update defect issue template to improve wording
bdba1a8 
Improve wording around rageshakes based on feedback.

Fixes #4987

Signed-off-by: Ekaterina Gerasimova <[email protected]>
@SBiOSoftWhare
Merge branch 'master' into develop
bab09ca
@SBiOSoftWhare
Prepare for new sprint
ef7958f
@stefanceriu
/issues/5041 - Fixed share extension and message forwarding room list…
fe98559 
… accessory view icon.
@stefanceriu
Fixes /issues/5042 - Message composer doesn't follow keyboard when sw…
3580207 
…iping to dismiss.
@stefanceriu
/issues/4384 - Using mutable room list fetch sort options after chani…
75eddf3 
…ng them to be a structure.
@pixlwave
Merge pull request #4988 from kittykat/issue-template
8768eb2 
Update defect issue template to improve wording
@stefanceriu
/issues/4976 - Replaced GrowingTextView with simpler, custom implemen…
efa726b 
…tation. Cleaned up the RoomInputToolbar header.
@stefanceriu
/issues/4976 - Fixed placeholder not displaying after being hidden fo…
7e6e82d 
…r resize animations.
@stefanceriu
Merge pull request #5052 from vector-im/stefan/4976-input-toolbar-tex…
04aaec2 
…t-view

/issues/4976 - Replaced GrowingTextView with sim…
@pixlwave
Send original data when when the compression prompt is disabled.
0ac42bb 
Rebase changes on develop.
@pixlwave
Re-order UTI types to prevent URLs being sent as text.
8f81292
@pixlwave
Remove image orientation checks.
0b1e778 
Images are still reoriented when resizing, but when sending the original data this isn't necessary.
@SBiOSoftWhare
RecentsViewController: Prevent retain cycles.
1ba2abe
@SBiOSoftWhare
RoomVC: Prevent retain cycles.
03cdf3d
@SBiOSoftWhare
NavigationRouter: in didPopViewController call run completion after s…
c1095a6 
…ending notification in order to send the right module instance.
@SBiOSoftWhare
RoomCoordinator: Fix RoomVC reatin issue.
24e0713
@SBiOSoftWhare
TabBarCoordinator: Prevent to update master tab bar controllers when …
dd5f7d6 
…not needed.
@SBiOSoftWhare
Add changes
9e145b9
@SBiOSoftWhare @pixlwave
Update Riot/Modules/Common/Recents/RecentsViewController.m
3a732b4 
Co-authored-by: Doug <[email protected]>
@SBiOSoftWhare @pixlwave
Update Riot/Modules/TabBar/TabBarCoordinator.swift
1c6ae4c 
Co-authored-by: Doug <[email protected]>
@SBiOSoftWhare
TabBarCoordinator: Fix space switching.
920e8e0
@SBiOSoftWhare
RoomVC: Fix typo.
9fc412f
@SBiOSoftWhare
Merge pull request #5056 from vector-im/steve/5055_roomvc_retain_cycles
cd8a428 
RoomVC: Retain cycles prevent RoomViewController to be deallocated
@SBiOSoftWhare
GroupsViewController: Prevent retain cycles.
ea7983a
@SBiOSoftWhare
SegmentedViewController: Prevent retain cycles.
1b63507
@SBiOSoftWhare
ContactDetailsViewController: Prevent retain cycles.
4361a59
@SBiOSoftWhare
SettingsViewController: Prevent retain cycles.
df472c1
@SBiOSoftWhare
Update weak views usage.
a05c488
@pixlwave
Send videos as 320p to encrypted rooms.
4d4612e
SBiOSoftWhare and others added 17 commits October 29, 2021 11:59
@SBiOSoftWhare
ContactsTableViewController: Prevent retain cycles.
222db3c
@SBiOSoftWhare
EnterNewRoomDetailsViewController: Prevent retain cycles.
f5f44f0
@SBiOSoftWhare
Update GroupDetailsCoordinator.
b31937b
@SBiOSoftWhare
Add changes
db4172e
@SBiOSoftWhare
Weakify strong reference delegates.
41eca48
@SBiOSoftWhare
RoomInfoListViewController: Weakify self in a closure.
7b44443
@SBiOSoftWhare
RoomSearchViewController: Fix setup.
d967d35
@SBiOSoftWhare
RoomViewController: Fix a crash on before iOS 14.
e33f077
@pixlwave
Merge pull request #5059 from vector-im/doug/4815_share_extension_prompt
d0555b5 
Handle showMediaSizeSelection in the share extension.
@pixlwave @stefanceriu
Fix avatars and hide spaces in Share Extension.
baef854
@SBiOSoftWhare
TabBarCoordinator: Improve tab bar controllers management. Avoid to h…
b362b4c 
…ave twice HomeVC in memory.
@SBiOSoftWhare @pixlwave
Update Riot/Modules/Room/RoomInfo/RoomInfoCoordinator.swift
22d48c7 
Co-authored-by: Doug <[email protected]>
@SBiOSoftWhare
Merge pull request #5061 from vector-im/steve/5058_fix_retain_cycles
88d46cd 
Fix retain cycles
@stefanceriu
Fixes /issues/5063 - Fixed retain cycles between the user suggestion …
37adc8a 
…coordinator and the suggestion service, and in the suggestion service currentTextTrigger subject sink.
@SBiOSoftWhare
SplitViewCoordinator: Fix detail screen reset behaviour.
8a5e6ad
@SBiOSoftWhare
Update changes
d1a4317
@SBiOSoftWhare
Fix typo
29b0507
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/M9uTSb

@SBiOSoftWhare SBiOSoftWhare deleted the steve/5084_fix_leaving_room branch November 3, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SBiOSoftWhare @kittykat @stefanceriu @pixlwave